RemoveHyperlinks Action deletes entire text instead of only removing hyperlink

[tomr]

Hello TRichView Support,
after running the RemoveHyperlinks action, both the hyperlink and its text are removed. I can reproduce this behavior in your RichViewActionTest demo.

Steps to reproduce:
Start the RichViewActionTest program. The sample text is displayed as expected.

RichviewActionTestLinks.png (39.95 KiB) Viewed 363 times

Select the hyperlink in the text and execute the RemoveHyperlinks action.

Remove Hyperlinks 1.png (20.2 KiB) Viewed 363 times

→ The hyperlink is removed, and the text appears with the default formatting. This works as intended.

Text ohne Hyperlink.png (6.69 KiB) Viewed 363 times

Now insert the link www.google.com and press Enter. It is correctly displayed as a hyperlink.

Hyperlink erstell.png (8.2 KiB) Viewed 363 times

Select this newly created hyperlink and run the RemoveHyperlinks action again.

Remove Hyperlinks 2.png (20.24 KiB) Viewed 363 times

→ This time, the entire text is deleted.

Is there a way to remove only the hyperlink without deleting the text?

[Sergey Tkachenko]

I confirm the problem. A fixed version will be released soon.
Quick fix:
Open RichViewActions.pas.
Find the code:

Code: Select all

        if AllowChangingText and (StartNo = EndNo) and
          (rve.GetItemStyle(i) >= 0) and
          (rve.GetItemTag(i) = rve.GetItemTextW(i)) then
        begin
          rve.SetItemTextEd(i, String(NewTag));

change to:

Code: Select all

        if AllowChangingText and (NewTag <> '') and (StartNo = EndNo) and
          (rve.GetItemStyle(i) >= 0) and
          (rve.GetItemTag(i) = rve.GetItemTextW(i)) then
        begin
          rve.SetItemTextEdW(i, NewTag);

[Sergey Tkachenko]

Fixed in TRichView 24.0.3

[tomr]

Hi Sergey,
thank you for your help. I implemented the quickfix and everything is working fine.